Skip to content

Skip printing user code when verification URI already includes it#1595

Merged
hslatman merged 1 commit intomasterfrom
herman/oauth-device-authorization-skip-code
Mar 17, 2026
Merged

Skip printing user code when verification URI already includes it#1595
hslatman merged 1 commit intomasterfrom
herman/oauth-device-authorization-skip-code

Conversation

@hslatman
Copy link
Member

@hslatman hslatman commented Mar 17, 2026

When VerificationURIComplete is present in the device authorization response, the user code is already embedded in the URI. Printing the code separately is redundant and potentially confusing.

This suppresses the code prompt in that case and shows only the complete URI.

This is related to #1430, and the behavior is in line with kubelogin

Also see #1430 (comment).

Change-Type: behavior
Release-Note: yes
Audience: user
Impact: low
Breaking: false

When VerificationURIComplete is present in the device authorization
response, the user code is already embedded in the URI. Printing
the code separately is redundant and potentially confusing.

This suppresses the code prompt in that case and shows only the
complete URI.

This is related to #1430, and
the behavior is in line with `kubelogin`

Change-Type: behavior
Release-Note: yes
Audience: user
Impact: low
Breaking: false
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Mar 17, 2026
@hslatman hslatman added this to the v0.30.0 milestone Mar 17, 2026
@hslatman hslatman marked this pull request as ready for review March 17, 2026 11:19
@hslatman hslatman requested a review from a team March 17, 2026 11:19
@hslatman hslatman merged commit 74af5a6 into master Mar 17, 2026
18 of 20 checks passed
@hslatman hslatman deleted the herman/oauth-device-authorization-skip-code branch March 17, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage Waiting for discussion / prioritization by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants